-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add blocking end-to-end tests for lifecycle hooks #6761
🌱 Add blocking end-to-end tests for lifecycle hooks #6761
Conversation
dada8ea
to
3b0cd95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first round of review.
Overall I like the way it's implemented I just struggle a bit with the func names in cluster_upgrade_runtimesdk.go to be honest. I'll take a closer look on the next round
e6a5c4d
to
8d1dda7
Compare
Mostly nits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits, + the comments from @sbueringer 👍 great stuff 🎉
0320e57
to
6a9a64c
Compare
6a9a64c
to
659bf22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, just a question from my side
659bf22
to
10de334
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
10de334
to
2da9619
Compare
/lgtm Great work, thx! +/- green test |
/cherry-pick release-1.2 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #6800 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon kmuldoon@vmware.com
Add blocking behaviour to the lifecycle hook e2e test introduced in #6664
Part of #6546
/area runtime-sdk