Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Runtime sdk/flaky e2e fix #6817

Merged
merged 1 commit into from
Jul 12, 2022
Merged

🌱 Runtime sdk/flaky e2e fix #6817

merged 1 commit into from
Jul 12, 2022

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Jul 4, 2022 •
edited
Loading

Signed-off-by: killianmuldoon kmuldoon@vmware.com

This PR updates the blocking e2e tests added in #6761 to use RetryAfterSeconds. This avoids triggering an exponential backoff in the reconciler and may help to resolve some flakes in the current tests.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 4, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 4, 2022
@sbueringer sbueringer mentioned this pull request Jul 5, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/flaky-e2e-fix branch 2 times, most recently from 277402a to 64f1ab7 Compare July 5, 2022 18:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/flaky-e2e-fix branch 2 times, most recently from 024c03a to 4e66900 Compare July 5, 2022 18:52
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2022
ykakarap
ykakarap reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a WIP. Doing just a high level review. The overall approach looks good.

Will do another review once reaedy.

test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
@chrischdi chrischdi mentioned this pull request Jul 7, 2022
Merged
1 task
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/flaky-e2e-fix branch 2 times, most recently from ef2ac80 to 8487264 Compare July 8, 2022 14:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/flaky-e2e-fix branch 3 times, most recently from 67ded7a to 62b6f55 Compare July 8, 2022 15:22
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-informing-main

@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Runtime sdk/flaky e2e fix 🌱 Runtime sdk/flaky e2e fix Jul 8, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2022
@killianmuldoon
Copy link
Contributor Author

This has passed three times now - https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-cluster-api-e2e-informing-main - I'm going to run it a number of times to make sure this fixes the flake as it's pretty disruptive on PRs at this point.

sbueringer
sbueringer reviewed Jul 8, 2022
View reviewed changes
test/extension/handlers/lifecycle/handlers.go Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

sbueringer commented Jul 8, 2022 •
edited
Loading

I'm going to run it a number of times to make sure this fixes the flake as it's pretty disruptive on PRs at this point.

Thx!

Of course it confuses folks anyway, but this job is optional for merge (exactly because we weren't sure everything (CC+RuntimeSDK) is 100% stable yet)

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-informing-main

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-informing-main

3 similar comments
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-informing-main

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-informing-main

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-informing-main

ykakarap
ykakarap reviewed Jul 9, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending the open comments

test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
ykakarap
ykakarap approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
@sbueringer
Copy link
Member

/approve

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/approve

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit cb6dad2 into kubernetes-sigs:main Jul 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 12, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 12, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #6897

In response to this:

/approve

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@ykakarap ykakarap ykakarap approved these changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@killianmuldoon @sbueringer @k8s-infra-cherrypick-robot @k8s-ci-robot @fabriziopandini @ykakarap