-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add BeforeClusterDelete to runtimeSDK e2e tests #6805
🌱 Add BeforeClusterDelete to runtimeSDK e2e tests #6805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very highg level review. Will do another round of review later.
962c4b0
to
6eac2cc
Compare
273b824
to
9b384af
Compare
4292cc9
to
f9c7e14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits. Otherwise lgtm (considering we'll do some improvements in #6817)
f9c7e14
to
5aa0e7d
Compare
Thx! /lgtm Note for other reviewers: There is some work going on stabilizing the e2e test a bit in #6817, but this is independent of this PR |
/lgtm |
5aa0e7d
to
bcda36c
Compare
/lgtm after rebase |
/lgtm |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits (non-blocking). Great work!
/lgtm
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
bcda36c
to
7587e2c
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.2 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini: new pull request created: #6849 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon kmuldoon@vmware.com
Adds the BeforeClusterDelete hook to the runtimeHook upgrade end to end test.
#6546