Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add BeforeClusterDelete to runtimeSDK e2e tests #6805

Merged
merged 1 commit into from
Jul 6, 2022
Merged

🌱 Add BeforeClusterDelete to runtimeSDK e2e tests #6805

merged 1 commit into from
Jul 6, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon kmuldoon@vmware.com

Adds the BeforeClusterDelete hook to the runtimeHook upgrade end to end test.

#6546

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2022
ykakarap
ykakarap reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very highg level review. Will do another round of review later.

test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/add-beforeClusterDelete-e2e-test branch from 962c4b0 to 6eac2cc Compare July 4, 2022 11:56
@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Add BeforeClusterDelete to runtimeSDK e2e tests 🌱 Add BeforeClusterDelete to runtimeSDK e2e tests Jul 4, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/add-beforeClusterDelete-e2e-test branch 3 times, most recently from 273b824 to 9b384af Compare July 4, 2022 12:06
sbueringer
sbueringer reviewed Jul 4, 2022
View reviewed changes
test/extension/handlers/lifecycle/handlers.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/add-beforeClusterDelete-e2e-test branch 4 times, most recently from 4292cc9 to f9c7e14 Compare July 4, 2022 16:30
sbueringer
sbueringer reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits. Otherwise lgtm (considering we'll do some improvements in #6817)

test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/add-beforeClusterDelete-e2e-test branch from f9c7e14 to 5aa0e7d Compare July 5, 2022 09:26
@sbueringer
Copy link
Member

sbueringer commented Jul 5, 2022 •
edited

Thx!

/lgtm

Note for other reviewers: There is some work going on stabilizing the e2e test a bit in #6817, but this is independent of this PR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@sbueringer sbueringer mentioned this pull request Jul 5, 2022
Closed
8 tasks
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/add-beforeClusterDelete-e2e-test branch from 5aa0e7d to bcda36c Compare July 5, 2022 12:13
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 5, 2022
@chrischdi
Copy link
Member

/lgtm

after rebase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@sbueringer
Copy link
Member

/lgtm

@killianmuldoon
Copy link
Contributor Author

/retest

ykakarap
ykakarap reviewed Jul 5, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits (non-blocking). Great work!

/lgtm

test/extension/handlers/lifecycle/handlers.go Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@killianmuldoon
Add BeforeClusterDelete to runtimeSDK e2e tests
7587e2c 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/add-beforeClusterDelete-e2e-test branch from bcda36c to 7587e2c Compare July 6, 2022 09:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@fabriziopandini
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 881903d into kubernetes-sigs:main Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 6, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 6, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #6849

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@ykakarap ykakarap ykakarap left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@killianmuldoon @sbueringer @chrischdi @fabriziopandini @k8s-ci-robot @k8s-infra-cherrypick-robot @ykakarap