Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] 🐛 kcp: patch ImageRepository in ClusterConfiguration if it is not set for v1.25 #6957

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #6917

/assign chrischdi

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 19, 2022
@fabriziopandini
Copy link
Member

/hold
Let's make sure the change runs on main with green CI for a couple of days first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@sbueringer
Copy link
Member

Agree with the hold. But we eventually have to merge this PR first, even if there is a follow-up bugfix.

@chrischdi
Copy link
Member

chrischdi commented Jul 22, 2022

Test was green for main branch for two times in series.

@fabriziopandini : we should also either:

@chrischdi
Copy link
Member

The tests on main now got green for 6 times in a row: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-e2e-main-1-24-latest 🎉

@fabriziopandini
Copy link
Member

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit ff276d6 into kubernetes-sigs:release-1.2 Jul 25, 2022
@chrischdi
Copy link
Member

For reference: periodic is now green 🎉

@sbueringer sbueringer mentioned this pull request Aug 29, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants