Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update versions doc adding Kubernetes 1.26 #7801

Merged
merged 1 commit into from
Jan 11, 2023
Merged

🌱 Update versions doc adding Kubernetes 1.26 #7801

merged 1 commit into from
Jan 11, 2023

Conversation

aniruddha2000
Copy link
Contributor

Signed-off-by: Aniruddha Basak codewithaniruddha@gmail.com

part of #7671

cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 23, 2022
killianmuldoon
killianmuldoon approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2022
@sbueringer
Copy link
Member

Looks good
/lgtm

Let's just
/hold
until the other PRs are merged (aka we actually support and test v1.26)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2022
@aniruddha2000
Update versions doc adding Kubernetes 1.26
1da245a 
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2023
@sbueringer
Copy link
Member

sbueringer commented Jan 2, 2023 •
edited
Loading

Let's decide if we want to commit to supporting v1.26 also in v1.2 and then update the affected PRs accordingly

@sbueringer
Copy link
Member

Let's decide if we want to commit to supporting v1.26 also in v1.2 and then update the affected PRs accordingly

Added a comment here: #7671 (comment)

Given that:
/lgtm

(let's merge after the quickstart PR)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0f31c57590cc705a530ec8e6b361adbc7d366d9

This was referenced Jan 2, 2023
Closed
Merged
Merged
@sbueringer
Copy link
Member

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@sbueringer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1cdd517 into kubernetes-sigs:main Jan 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@oscr oscr Awaiting requested review from oscr

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@aniruddha2000 @sbueringer @k8s-ci-robot @fabriziopandini @killianmuldoon