-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks to bump to Kubernetes v1.26 #7671
Comments
/triage accepted |
FYI this issue seems linked to this work |
Yup thx it is. @ykakarap can you please add it as release related task to the 2nd section? (Using new Kubernetes dependencies) |
done |
/assign I would like to work on this 😊 |
Regarding the prerequisite:
Let's start with the assumption that we implement it on main and only cherry-pick it into release-1.3. I think we have to discuss it (and I wanted to bring this up anyway next year) but this shouldn't block the work for main and release-1.3. We can then still additionally cherry-pick back into release-1.2 after we made the decision. |
Quick update. I discussed with Fabrizio if we should support v1.26 in v1.2. Given:
We would support v1.26 in v1.2. We are interpreting "best-effort" as we are trying to support it except if we find a major showstopper while implementing it. Independent of that I'll bring up the discussion if we want to support new Kubernetes releases in "older" stable releases in the future. But this won't affect the Kubernetes 1.26 bump. |
Is there any reference I can look to find the go minor version Kubernetes is using? |
I usually refer to the release notes: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.26.md Not sure why the latest entry there is 1.19.3. The 1.26 kubekins image is using v1.19.4. But given that we only need to know the minor version it's good enough. So tl;dr we don't have to bump further as we are already using 1.19 P.S. I updated the task list accordingly mit "does not apply" |
What would be the @sbueringer can you describe what kind of work I have to do here?
|
v0.26.0 is perfect
Let's start with the ones below "Modify quickstart and CAPD to use the new Kubernetes release". Essentially open PRs against release-1.3 and release-1.2 with a cherry-pick of the commit from #7799 We always try to do this with the bot but because of conflicts that's not always possible (#7799 (comment)) I would say start with opening a PR against release-1.3 and try to best-effort resolve the conflicts the way you think it's correct. I'll take a closer look once the PR is open and let you know if there is more to do. |
@aniruddha2000 Do you have time to work on those cherry-picks and on the findings on kubernetes/test-infra#28309? Otherwise I"m happy to take this over. I just want to reduce the time that our branches (and jobs) are in different states. |
@sbueringer Yes I will open the cherry picks by today and will resolve the findings One query for the cherry-pick is |
No worries, feel free to ask as many questions as you want :)
Yes That's what I tried to say here: |
Quick update about the current state / merge order. Next steps:
I'll start merging the PRs (when they are ready) after the patch releases |
Okay all of them are merged now. Kudos again to @aniruddha2000 ! Next up would be bumping controller-runtime (v0.14.1) and controller-tools v0.11.1 (only on main) (I read through both release notes it should be mostly bumping the versions, making sure it still compiles / tests are green) @aniruddha2000 Do you want to take care of this as well? |
Yes, @sbueringer I can. But are there any specific places where I have to make the changes? or it's the project-level controller-runtime & controller-tools in the go.mod file? |
controller-tools is bumped in the Makefile |
Controller-runtime should be bumped in all of our go.mod files + documented in the migration doc |
Perfect. We're almost done. One last task: I'll take a closer look at that one later. I think it just comes down to making sure our next release notes contain a note (I just want to verify something to make sure we add the right note) |
All the items in the list are complete! Bumping to support Kubernetes v1.26 is now complete. Big thanks to everyone who helped with this effort! 👏🏼 /close |
@ykakarap: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is now tracked in the release tracking issue. |
This issue is tracking the tasks that should be implemented after the Kubernetes minor release has been released.
Tasks
Prerequisites:
Supporting managing and running on the new Kubernetes version
This section contains tasks to update our book, e2e testing and CI to use and test the new Kubernetes version
as well as changes to Cluster API that we might have to make to support the new Kubernetes version. All of these
changes should be cherry-picked to all release series that will support the new Kubernetes version.
test/*
: search for occurrences of the previous Kubernetes versionTiltfile
INIT_WITH_KUBERNETES_VERSION
.versions.md
jobs.md
a new Kubernetes minor version. Please add these issues here when they are identified.
Using new Kubernetes dependencies
This section contains tasks to update Cluster API to use the latest Kubernetes Go dependencies and related topics
like using the right Go version and build images. These changes are only made on the main branch. We don't
need them in older releases as they are not necessary to manage workload clusters of the new Kubernetes version or
run the Cluster API controllers on the new Kubernetes version.
main
branch to use the correctkubekins-e2e
image.github/workflows
,hack/ensure-go.sh
,.golangci.yml
,cloudbuild*.yaml
,go.mod
,Makefile
,netlify.toml
,Tiltfile
KUBEBUILDER_ENVTEST_KUBERNETES_VERSION
inMakefile
releases and is not strictly necessary for Supporting managing and running on the new Kubernetes version.
CONVERSION_GEN_VER
inMakefile
The text was updated successfully, but these errors were encountered: