Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Use Kubernetes 1.25 in Quick Start docs and CAPD. #7156

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Sep 2, 2022

What this PR does / why we need it:

Updates the Quick Start guide to use Kubernetes 1.25. Now using kind 0.15.0 and Calico 3.24.1.

Calico was updated due to breakage error: unable to recognize "https://docs.projectcalico.org/v3.21/manifests/calico.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1".

The updated QS "works on my machine" and all pods in management and worker cluster seem to be running.

Part of #6661

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2022
@oscr
Copy link
Contributor Author

oscr commented Sep 2, 2022

/test pull-cluster-api-e2e-informing-main

test/e2e/cluster_upgrade_runtimesdk_test.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
test/e2e/config/docker.yaml Outdated Show resolved Hide resolved
test/framework/machinepool_helpers.go Outdated Show resolved Hide resolved
test/e2e/config/docker.yaml Outdated Show resolved Hide resolved
test/e2e/config/docker.yaml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk_test.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_test.go Outdated Show resolved Hide resolved
test/e2e/config/docker.yaml Outdated Show resolved Hide resolved
test/framework/machinepool_helpers.go Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Sep 2, 2022
29 tasks
@sbueringer
Copy link
Member

/test ?

@k8s-ci-robot

This comment was marked as outdated.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

@oscr oscr force-pushed the update-quickstart-kind-15 branch 3 times, most recently from 248ee40 to 80e49ff Compare September 2, 2022 11:14
@sbueringer
Copy link
Member

lgtm pending full tests

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

@sbueringer
Copy link
Member

sbueringer commented Sep 2, 2022

After merge we should do a manual cherry-pick PR against release-1.2 with the following delta:

  • let's try to keep the kind version on v0.14.0 (should work based on a local test)

Just to avoid bumping a dependency to another minor version in a CAPI patch release

@oscr
Copy link
Contributor Author

oscr commented Sep 2, 2022

After merge we should do a manual cherry-pick PR against release-1.2 with the following delta:

* let's try to keep the kind version on v0.14.0 (should work based on a local test)

Since the default image has changed between 0.14 and 0.15, do you mean explicitly setting the image when creating clusters? For example by adding --image kindest/node:v1.25.0

@oscr
Copy link
Contributor Author

oscr commented Sep 2, 2022

https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125

I suspect we need to look at this. I will see what I can do.

@sbueringer
Copy link
Member

sbueringer commented Sep 2, 2022

Since the default image has changed between 0.14 and 0.15, do you mean explicitly setting the image when creating clusters? For example by adding --image kindest/node:v1.25.0

Should be fine our test framework sets the image when it creates the mgmt cluster programmatically:

clusterProvider = bootstrap.CreateKindBootstrapClusterAndLoadImages(ctx, bootstrap.CreateKindBootstrapClusterAndLoadImagesInput{
Name: config.ManagementClusterName,
KubernetesVersion: config.GetVariable(KubernetesVersionManagement),
RequiresDockerSock: config.HasDockerProvider(),
Images: config.Images,
IPFamily: config.GetVariable(IPFamily),
LogFolder: filepath.Join(artifactFolder, "kind"),
})

(based on docker.yaml KUBERNETES_VERSION_MANAGEMENT)

@oscr oscr force-pushed the update-quickstart-kind-15 branch 2 times, most recently from 89f4d62 to cfbde71 Compare September 2, 2022 12:41
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2022
@oscr
Copy link
Contributor Author

oscr commented Sep 3, 2022

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

@oscr
Copy link
Contributor Author

oscr commented Sep 4, 2022

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main

@sbueringer
Copy link
Member

Thank you very much!!

/lgtm

/assign @fabriziopandini
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2022
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small nit :-) lgtm except that 👍

Great work 🎉

docs/book/src/user/quick-start.md Show resolved Hide resolved
Use kind 0.15.0 and Calico 3.24.1 in the Quick Start.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2022
@oscr
Copy link
Contributor Author

oscr commented Sep 5, 2022

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
/test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2022
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main

1 similar comment
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, thanks for taking care of this task!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit d89adf8 into kubernetes-sigs:main Sep 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 6, 2022
@oscr oscr deleted the update-quickstart-kind-15 branch September 6, 2022 08:38
@ykakarap ykakarap mentioned this pull request Nov 30, 2022
13 tasks
@joekr joekr mentioned this pull request Apr 3, 2023
12 tasks
@ykakarap ykakarap mentioned this pull request May 20, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants