-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks to bump to Kubernetes v1.27 #8459
Comments
/triage accepted |
I can take care of it, once v1.27 is out (which is scheduled on Tuesday 11th April 2023) /assign |
IMO we shouldn't assign this issue as a whole - given there's a bunch of separate parts it might make it tougher to keep track of. @furkatgofurov7 - do you want to take the first section i.e. all points under |
@killianmuldoon thanks sure, I did not think of a possible complication, let's break it down then into parts and work on them separately. |
Thanks @furkatgofurov7! Just want to make sure we don't miss stuff as it comes up 🙂 |
@joekr I can take care of, |
@Prajyot-Parab hey, I am planning to work on the first section |
/assign @Prajyot-Parab (for section 2) |
FYI, kubernetes v1.27 is live now and we can start working on this issue. |
Please (also) assign me for reviews of the PRs (on the PRs) outside of the core CAPI repository (probably only test-infra). I'll see the PRs in core CAPI anyway, but I would also like to review the ones in test-infra. |
Ideally we have someone who ensures the umbrella issue (aka the top-level issue description) is always up-to-date, by linking the opened PRs and checking the completed tasks. (this also includes verifying that we cherry-pick everything into the appropriate branches) Based on permissions this can only be done by either @joekr or one of the CAPI maintainers (because only they have write access to the issue description). I can help out there, except someone else wants to. |
About the prereq:
Based on our policy
I think we should only cherry-pick into release-v1.4. Which means v1.4.x and v1.5.0 will support v1.27. We should probably update the issue template to reflect the new policy. The current issue template was created before we established the policy |
I'm going to slowly start moving these long running release tasks into a release project https://github.com/orgs/kubernetes-sigs/projects/37/views/1. This way we can hand over outstanding issues instead of creating a new tracking issue for each release. This will also allow folks to update tasks. Then once they are ready to work them or need to open a discussion we can convert to issues easier than a single issue owner. |
I'm not sure I understand, we have distinct tasks for each new Kubernetes bump. In which way are these tasks long running and have to be handed over? |
Agree, most probably the comment more relevant to the tracking issue where we have improvement tasks but not this one. |
@sbueringer PTAL at kubernetes/test-infra#29295 and other CAPI PRs' linked here whenever you have some spare time, thanks! |
I would definitely like to not lose the clarity and traceability (also going forward) that this umbrella issue provides. |
Thx for the ping, on my list! |
@Prajyot-Parab If it's okay for you I would like to continue the work on "Bump controller-runtime" that I started a while back here: #8007 |
Sure np! |
FYI there is already a PR to upgrade k8s to v0.27 in |
I think we're mixing up a few things.
(This is mostly an answer to Joe's and Killian's comments) @Prajyot-Parab We don't have to ensure there will be a new CR release after the client-go bump in controller-runtime. I and the other CR maintainers are on it and the current estimation is that there will be a CR release (including client-go v0.27) the week after KubeCon. Hope this helps :) |
presubmit jobs - kubernetes/test-infra#29313 |
Alright, @sbueringer @joekr folks here is a notes with list of PRs' we need to update with in the umbrella issue description and I need your help with and hope makes it easy also for you to track:
|
WOW! @furkatgofurov7 this is amazing! Thank you so much for driving these to completion. |
Using new Kubernetes dependencies
|
Hey folks, I am working on bumping |
@odvarkadaniel CAPI currently supports workload clusters on v1.27, but the underlying Kubernetes libraries have not been bumped yet. We'll do that once controller runtime releases a version that uses the underlying Kubernetes libraries as stated in the checklist in this issue under Using new Kubernetes dependencies. Is this the update that's blocking you? |
Thanks for pointing me to the right item in the list, @killianmuldoon. |
This is stuck ~ here: (basically it depends on Kubernetes 1.27.2 in ~ mid May) |
Just fyi, there is nothing to do regarding: "issues specific to the Kubernetes minor release" We didn't get notified about anything and CI is green. So this sub-task is also completed |
Probably tracked somewhere else but "Bump the Go version in Cluster API: (if Kubernetes is using a new Go minor version)" is not completed yet. After we got the new image for cloudbuild (kubernetes/test-infra#29357) we have to bump the image in our cloud build YAMLs in CAPI to General comment. The second section can be also completed afaik apart from the controller-runtime / controller-tools tasks, but we don't have to wait for them |
|
@Prajyot-Parab do you have time to open a PR to bump KUBEBUILDER_ENVTEST_KUBERNETES_VERSION? |
sure! |
Do we need to cherry pick this one as mentioned in the description, If yes then in which release branches? |
UPDATE: I said just below we can cherry pick on the PR when done. |
It should be cherrypicked into 1.4. The idea is to run our tests against the newest kubernetes version that we support |
Thx everyone. This is now comlpeted as we merged the CR bump. /close |
@sbueringer: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is tracking the tasks that should be implemented after the Kubernetes minor release has been released.
Tasks
Prerequisites:
Supporting managing and running on the new Kubernetes version (@furkatgofurov7)
This section contains tasks to update our book, e2e testing and CI to use and test the new Kubernetes version
as well as changes to Cluster API that we might have to make to support the new Kubernetes version. All of these
changes should be cherry-picked to all release series that will support the new Kubernetes version.
test/*
: search for occurrences of the previous Kubernetes versionTiltfile
InitWithKubernetesVersion
inclusterctl_upgrade_test.go
KUBEBUILDER_ENVTEST_KUBERNETES_VERSION
of thetest-mink8s
jobs to the new minimum supported management cluster version.KUBERNETES_VERSION_MANAGEMENT
of thee2e-mink8s
job to the new minimum supported management cluster version.versions.md
jobs.md
a new Kubernetes minor version. Please add these issues here when they are identified.
Using new Kubernetes dependencies (@Prajyot-Parab)
This section contains tasks to update Cluster API to use the latest Kubernetes Go dependencies and related topics
like using the right Go version and build images. These changes are only made on the main branch. We don't
need them in older releases as they are not necessary to manage workload clusters of the new Kubernetes version or
run the Cluster API controllers on the new Kubernetes version.
main
branch to use the correctkubekins-e2e
imagehack/ensure-go.sh
,.golangci.yml
,cloudbuild*.yaml
,go.mod
,Makefile
,netlify.toml
,Tiltfile
KUBEBUILDER_ENVTEST_KUBERNETES_VERSION
inMakefile
releases and is not strictly necessary for Supporting managing and running on the new Kubernetes version.
CONVERSION_GEN_VER
inMakefile
The text was updated successfully, but these errors were encountered: