-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Bump to CR v0.15.0 #8007
⚠️ Bump to CR v0.15.0 #8007
Conversation
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
Outdated
Show resolved
Hide resolved
d0c7a38
to
e1403a3
Compare
3367210
to
8e4639b
Compare
5deba93
to
15e170a
Compare
/test pull-cluster-api-e2e-full-main |
@sbueringer: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This lgtm, great work not just getting these changes up, but queuing them up for 6+ months so that it's ready to land when everything else has been done to allow this! |
echo to this, really great work /lgtm |
LGTM label has been added. Git tree hash: bda60e6faf36884a7fe8661d1c80ba9805bc2b9f
|
@@ -36,3 +39,22 @@ maintainers of providers and consumers of our Go API. | |||
### Suggested changes for providers | |||
|
|||
- | |||
|
|||
## Notes about the controller-runtime bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thank you for adding detailed notes here
/lgtm Just to add on top of everyone else saying this - great work! It took a lot to track this over months of underlying changes in both CAPI and controller runtime - thank you very much! |
Thx for the reviews everyone! I know it's not the most fun PR to review :) |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area dependency |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Notes:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #8459