-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Use k8s v1.27.0 in quickstart docs and CAPD #8518
⚠️ Use k8s v1.27.0 in quickstart docs and CAPD #8518
Conversation
/hold Manually verifying quickstart is pending |
ffa36ee
to
290f49e
Compare
Done and all good. /hold cancel |
/assign @sbueringer |
GH rate limit issue /test pull-cluster-api-e2e-informing-ipv6-main |
b6153f9
to
c4e425e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
/test pull-cluster-api-e2e-full-main ^^ this test has to be green before merge |
/retest |
/retest possibly a flake |
/retest |
@furkatgofurov7 @killianmuldoon Let's wait with test-infra PR merges until this PR is green |
Definitely consistent failure in the 0.3 upgrade test 🤔. I'll have a look certainly by tomorrow some time (could have been a good candidate for the hacking session 😄) |
c4e425e
to
d1e17ef
Compare
/test pull-cluster-api-e2e-full-main |
/retest |
Ups, is this test actually trying to create a 1.27 workload cluster with CAPI v0.3? INFO: Creating the workload cluster with name "clusterctl-upgrade-eq86nx" using the "(default)" template (Kubernetes v1.27.0, 1 control-plane machines, 1 worker machines) If I see this correctly we should introduce a new parameter to the test spec for the test cluster kubernetes version |
Context:
Proposal:
So we end up with the following:
InitWithKubernetesVersion is the version we deploy the old provider on Both those version should be the highest the old provider supports (this makes it very likely that the main version also supports those versions, and as of today that always works) Note: patch version should be the highest we have corresponding kindest/node image for on dockerhub. I looked them up and "bumped" them a bit. We don't have to continuously keep them up-to-date, but maybe let's do it now as we have to introduce WorkloadKubernetesVersion anyway @furkatgofurov7 @killianmuldoon @fabriziopandini @ykakarap Opinions? |
yeah, but that is the case with 0.4, as well no? And I saw that went fine 🤔 |
I could imagine that v0.4 is for some reason compatible with v1.27 (e.g. we use a newer client-go, controller-runtime version). But it should be relatively easy to see by running the failing test locally and just looking why the Machines are not coming up (I just don't have the time for it right now). I think we should definitely find out why the test is actually failing. I would do the suggested change in any case btw, even if we don't need it for this specific PR. It might just be the solution we need if we find out that v0.3 is simply not compatible with Kubernetes v1.27 |
45ef435
to
077d303
Compare
Running it once again to be sure nothing new was introduced while rebasing: /test pull-cluster-api-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for getting this one over the line - was a bit more complex than usual 🙂
/lgtm
LGTM label has been added. Git tree hash: ea2f0bacea383ae5e42a5af387f2a412defa62f7
|
Thank you very much!! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon @sbueringer thx folks, do we need to back-port it to release-1.4 branch? |
Yes, please! I think we can & should definitely prepare the PR already. Then we have to decide if we want to "officially" support 1.27 already in 1.4.2 or merge it intentionally afterwards to get more time in CI |
ack, let me try the cherry-picker and see if it can do it otherwise will manually cherry pick it: /cherry-pick release-1.4 |
@furkatgofurov7: #8518 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No chance with the migration doc :D |
Here: #8538 |
/area provider/infrastructure-docker e2e-testing documentation |
Signed-off by: Furkat Gofurov (furkat.gofurov@suse.com)
What this PR does / why we need it:
Bumps k8s version to v1.27.0 in Quickstart docs and CAPD.
NOTE:
3.5.7-0
following the kubeadmv1.10.1
following the kubeadmWorkloadKubernetesVersion
was introduced toClusterctlUpgradeSpecInput
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of: #8459
cc @kubernetes-sigs/cluster-api-release-team