Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 update autoscaling from zero proposal #8036

Merged
merged 1 commit into from
Feb 22, 2023
Merged

📖 update autoscaling from zero proposal #8036

merged 1 commit into from
Feb 22, 2023

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Jan 31, 2023

What this PR does / why we need it:

include the latest changes to the annotation that are proposed in the cluster autoscaler

ref: kubernetes/autoscaler#5382
ref: kubernetes/autoscaler#5416

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@elmiko
update autoscaling from zero proposal
a8e76e8 
to include latest changes to the annotation that are proposed in the
cluster autoscaler.

ref: kubernetes/autoscaler#5382
ref: kubernetes/autoscaler#5416
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2023
@elmiko
Copy link
Contributor Author

elmiko commented Jan 31, 2023

/hold until the related autoscaler PRs have merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
This was referenced Jan 31, 2023
Merged
Merged
@sbueringer
Copy link
Member

/lgtm

I assume we don't have to update the book, as the book embeds the README in the autoscaler repo.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4eff79fb46e443fe78b19f6e88f8f4e51c309c9

killianmuldoon
killianmuldoon approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elmiko
Copy link
Contributor Author

elmiko commented Feb 1, 2023

I assume we don't have to update the book, as the book embeds the README in the autoscaler repo.

correct, i just wanted to make sure we kept all the info accurate

@sbueringer
Copy link
Member

I assume we don't have to update the book, as the book embeds the README in the autoscaler repo.

correct, i just wanted to make sure we kept all the info accurate

Yup sure. Thanks for doing that! :)

@elmiko
Copy link
Contributor Author

elmiko commented Feb 22, 2023

the autoscaler change has merged
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6b40f8f into kubernetes-sigs:main Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elmiko @sbueringer @k8s-ci-robot @killianmuldoon