clusterapi: Add ephemeral disk capacity annotation for scale from zero #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts for scale from zero
k8s-ci-robot
added
kind/feature
|
this is a nice addition, thanks @cnmcavoy . i'll spend some time reviewing this week. |
|
i've created kubernetes-sigs/cluster-api#8036 to cover the docs update in cluster-api |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cnmcavoy, elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
pushed a commit
to kubernetes-sigs/cluster-api
that referenced
this pull request
Feb 22, 2023
to include latest changes to the annotation that are proposed in the cluster autoscaler. ref: kubernetes/autoscaler#5382 ref: kubernetes/autoscaler#5416
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Updates the clusterapi provider to support an additional capacity annotation for ephemeral disk capacity on MachineDeployments to supply information about the nodegroup shape.
Without an ephemeral disk capacity supplied, workloads that request ephemeral disk will not trigger a scale up of nodegroups with zero replicas as the ephemeral disk capacity defaults to zero bytes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: