Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 KCP: fix rollout after upgrade #8125

Merged
merged 1 commit into from
Feb 20, 2023
Merged

🐛 KCP: fix rollout after upgrade #8125

merged 1 commit into from
Feb 20, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 16, 2023 •
edited

What this PR does / why we need it:
For more details see the linked issue

Additional verification that the bug is fixed via: #8120 (I'm running the e2e test 10x in the e2e-main job there)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8124

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2023
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @killianmuldoon

@sbueringer
Copy link
Member Author

/hold
until a few more runs on #8120 proof that the issue is fixed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

ykakarap
ykakarap approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6602183aed9fbb6d851b07267c1d8858bdb6c9a6

@sbueringer
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-full-main f7fe7da link false /test pull-cluster-api-e2e-full-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/hold
Looks like we have another issue with clusterclass and MDs

@sbueringer
Copy link
Member Author

/hold cancel

/lgtm
/approve

To get CI back to green

@k8s-ci-robot
Copy link
Contributor

@sbueringer: you cannot LGTM your own PR.

In response to this:

/hold cancel

/lgtm
/approve

To get CI back to green

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit fd82dd2 into kubernetes-sigs:main Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 20, 2023
@sbueringer sbueringer deleted the pr-fix-kcp-rollout branch February 20, 2023 05:45
@sbueringer sbueringer mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

KCP triggers rollout after upgrade
5 participants
@sbueringer @k8s-ci-robot @ykakarap @fabriziopandini @killianmuldoon