Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaking test: Machines should remain the same after the upgrade #8101

Closed
aniruddha2000 opened this issue Feb 13, 2023 · 7 comments
Closed

flaking test: Machines should remain the same after the upgrade #8101

aniruddha2000 opened this issue Feb 13, 2023 · 7 comments
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@aniruddha2000
Copy link
Contributor

Failure cluster 6c739992d36a8dc546c4

Error text:
Failed after 30.070s.
Machines should remain the same after the upgrade
Expected
    <bool>: false
to be true
[FAILED] Failed after 30.070s.
Machines should remain the same after the upgrade
Expected
    <bool>: false
to be true
In [It] at: /home/prow/go/src/sigs.k8s.io/cluster-api/test/e2e/clusterctl_upgrade.go:451 @ 02/03/23 01:33:29.995

Recent failures:

13/2/2023, 6:30:02 pm periodic-cluster-api-e2e-mink8s-main
13/2/2023, 6:28:53 am periodic-cluster-api-e2e-mink8s-main
13/2/2023, 4:27:50 am periodic-cluster-api-e2e-mink8s-main
12/2/2023, 10:27:52 pm periodic-cluster-api-e2e-mink8s-main
12/2/2023, 8:27:04 pm periodic-cluster-api-e2e-mink8s-main

/kind failing-test

cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2023
@killianmuldoon
Copy link
Contributor

Thanks for opening this @aniruddha2000!

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2023
@sbueringer
Copy link
Member

Root cause will be fixed via: #8124

Let's keep this issue until we can verify that the e2e test on main has been stable for a while.

@sbueringer
Copy link
Member

Issue should be fixed for KCP

We have a similar issue with the Cluster topology controller (only affects v1.2 => main and v1.3 => main).

Working on this now.

For now disabling the rollout check to get back to green CI: #8138

@sbueringer
Copy link
Member

sbueringer commented Feb 21, 2023

Justed merged the fixes: #8125 & #8139

Now this issue shouldn't occur anymore

@sbueringer
Copy link
Member

@aniruddha2000 @furkatgofurov7 I think we can close this issue given that "Machines should remain the same after the upgrade" doesn't occur anymore. I think I would treat other flakes as a new issue.

@furkatgofurov7
Copy link
Member

Agree, thanks a lot for all hard work @sbueringer

/close

@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: Closing this issue.

In response to this:

Agree, thanks a lot for all hard work @sbueringer

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants