Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test/e2e: disable rollout check for ClusterClass-based cluster in clusterctl ugprade tests II #8140

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 20, 2023

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
:/

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #8101

clusterctl ugprade tests II

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2023
@sbueringer sbueringer changed the title 🌱 test/e2e: disable rollout check for ClusterClass-based cluster in 🌱 test/e2e: disable rollout check for ClusterClass-based cluster in clusterctl ugprade tests II Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-informing-main f7c3469 link false /test pull-cluster-api-e2e-informing-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/retest

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d2908740238c03caa0f6524af9a63635e3de250

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6887f96 into kubernetes-sigs:main Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 20, 2023
@sbueringer sbueringer deleted the pr-cc-rollout-after-upgrade-stopgap-2 branch February 20, 2023 16:09
@fabriziopandini
Copy link
Member

@sbueringer can we link the issue/PRs where we track the work for restoring this test?

@sbueringer
Copy link
Member Author

Thx, yup forgot to link it in this PR. I edited the PR description now.

For reference. This stopgap was later reverted in #8139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants