Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 ClusterClass: run dry-run on original and modified object #8139

Merged
merged 1 commit into from
Feb 21, 2023
Merged

🐛 ClusterClass: run dry-run on original and modified object #8139

merged 1 commit into from
Feb 21, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 20, 2023 •
edited

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #8101

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2023
@sbueringer sbueringer force-pushed the pr-cc-dry-run-both branch 2 times, most recently from 2efb80b to c01c786 Compare February 20, 2023 16:19
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

1 similar comment
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/retest

unrelated flake

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main
v1.2 => main & v1.3 => main passed 10x in this test, but just re-running for more data

@sbueringer sbueringer changed the title [WIP] 🐛 ClusterClass: run dry-run on original and modified object 🐛 ClusterClass: run dry-run on original and modified object Feb 20, 2023
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 20, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Feb 20, 2023 •
edited

Ran v1.2 => main and v1.3 => main (which are failing 100% in CI) each 10x on this PR (via some additional temporary test configs) and it always worked:

Removed that hack now and PR should be ready.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

cpanato
cpanato approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4afd8781d8878fe76bc09237bf224027b7fd7d9a

@sbueringer
Copy link
Member Author

/retest

independent error, will be fixed on Killian's PR

fabriziopandini
fabriziopandini reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, kudos for the tests

internal/controllers/topology/cluster/structuredmerge/dryrun.go Show resolved Hide resolved
internal/controllers/topology/cluster/structuredmerge/serversidepathhelper_test.go Show resolved Hide resolved
internal/controllers/topology/cluster/structuredmerge/serversidepathhelper_test.go Show resolved Hide resolved
@sbueringer
ClusterClass: run dry-run on original and modified object
4d3b181 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2023
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac12ead1e4bf3e57e97bc15bc2f13dace0a0c8db

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@fabriziopandini
Copy link
Member

Let's keep track somehow that we need to think to a solution to avoid dryRun calls when objects are not changed

@k8s-ci-robot k8s-ci-robot merged commit 7efddcf into kubernetes-sigs:main Feb 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 21, 2023
@sbueringer
Copy link
Member Author

Let's keep track somehow that we need to think to a solution to avoid dryRun calls when objects are not changed

I'll implement it (probably either today or tomorrow)

@sbueringer sbueringer deleted the pr-cc-dry-run-both branch February 21, 2023 12:32
This was referenced Feb 21, 2023
Closed
Closed
Closed
@furkatgofurov7 furkatgofurov7 mentioned this pull request Feb 21, 2023
Closed
This was referenced Feb 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@ykakarap ykakarap Awaiting requested review from ykakarap

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@cpanato cpanato

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbueringer @k8s-ci-robot @fabriziopandini @cpanato