🌱 Bump to controller-runtime v0.14.5 #8213
Conversation
k8s-ci-robot
added
cncf-cla: yes
sbueringer
changed the title
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
| @@ -14,6 +14,8 @@ pushgateway: | |||
| # Scrape metrics from deployed providers | |||
| extraScrapeConfigs: | | |||
| - job_name: 'capi-providers' | |||
| # 15s is a bit often for production but helps to get metrics quicker for development. | |||
There was a problem hiding this comment.
The idea was to make the metrics that we pick up with CR v0.14.5 better accessible in the dev env.
But I can move it to a separate PR if we prefer
There was a problem hiding this comment.
got it, IMO including this change in this PR makes sense
There was a problem hiding this comment.
Okay. I'm really fine either way
|
A bit of context: ~ waiting for this PR: kubernetes-sigs/controller-runtime#2219 |
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-bump-cr-v0.14.5
branch
from
5d450f8
to
06783ea
Compare
k8s-ci-robot
added
size/S
|
Should be ready now |
|
/test pull-cluster-api-e2e-full-main |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 21ab479106a6f38940bc4de133c1499b5173873a
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This PR picks up a new CR version which includes a few useful metrics for us:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #