-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.14] 🐛 Allow lazy restmapper to work with CRDs created at runtime #2219
[release-0.14] 🐛 Allow lazy restmapper to work with CRDs created at runtime #2219
Conversation
/hold |
fffd4f0
to
8337539
Compare
/test pull-controller-runtime-test-release-0-14 |
/retest |
/hold cancel |
Now lazy restmapper fetches all API resources once at start and then caches them. It prevents it from discovery of new CRDs created after the controller has started. This commit allows lazy restmapper to work with such CRDs.
8337539
to
66fe1a0
Compare
/assign @vincepri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.14.4` -> `v0.14.5` | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime</summary> ### [`v0.14.5`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.5) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.14.4...v0.14.5) #### What's Changed - 🐛 Allow to set GracefulShutdownTimeout to -1, disabling timeouts in [kubernetes-sigs/controller-runtime#2198 - 🌱 GVKForObject should handle multiple GVKs in Scheme gracefully in [kubernetes-sigs/controller-runtime#2202 - ✨ Add rest client request duration and size metrics in [kubernetes-sigs/controller-runtime#2218 - 🐛 Allow lazy restmapper to work with CRDs created at runtime in [kubernetes-sigs/controller-runtime#2219 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.4...v0.14.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1My4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.14.1` -> `v0.14.6` | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime</summary> ### [`v0.14.6`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.6) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.14.5...v0.14.6) #### What's Changed - 🐛 Preserve unstructured object GVKs when using \*ByObject cache options by [@​joelanford](https://github.com/joelanford) in [kubernetes-sigs/controller-runtime#2249 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.5...v0.14.6 ### [`v0.14.5`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.5) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.14.4...v0.14.5) #### What's Changed - 🐛 Allow to set GracefulShutdownTimeout to -1, disabling timeouts in [kubernetes-sigs/controller-runtime#2198 - 🌱 GVKForObject should handle multiple GVKs in Scheme gracefully in [kubernetes-sigs/controller-runtime#2202 - ✨ Add rest client request duration and size metrics in [kubernetes-sigs/controller-runtime#2218 - 🐛 Allow lazy restmapper to work with CRDs created at runtime in [kubernetes-sigs/controller-runtime#2219 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.4...v0.14.5 ### [`v0.14.4`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.4) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.14.3...v0.14.4) #### What's Changed - ✨ Provide a truly lazy restmapper by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2179 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.3...v0.14.4 ### [`v0.14.3`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.3) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.14.2...v0.14.3) #### What's Changed - ✨ Add additional SubResource\* functions for FieldOwner by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2153 - 🐛 Update golanci-lint script by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2152 - 🌱 Bump kubebuilder-release-tools to v0.3.0 by [@​k8s-infra-cherrypick-robot](https://github.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2154 - 🌱 \[0.14] Deprecate component configuration package by [@​vincepri](https://github.com/vincepri) in [kubernetes-sigs/controller-runtime#2165 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.2...v0.14.3 ### [`v0.14.2`](https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.2) [Compare Source](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.14.1...v0.14.2) #### What's Changed - \[release-0.14] 🌱 Bump k8s.io/\* to v0.26.1 by [@​sbueringer](https://github.com/sbueringer) in [kubernetes-sigs/controller-runtime#2146 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.14.1...v0.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/newrelic/newrelic-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Manual cherry-pick of #2208
There were conflicts in the test file. I just went with the version from main
EDIT: now resolved conflicts in a way that it works :)