🐛 clusterctl: return early if release for latest tag does not exist yet #8253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
chrischdi
commented
Mar 8, 2023
chrischdi
force-pushed
the
pr-clusterctl-404-error
branch
from
d2c9974
to
48d467a
Compare
|
Taking back to VIP to go over unit tests and add new ones /retitle WIP 🐛 clusterctl: return early if release for latest tag does not exist yet |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
chrischdi
force-pushed
the
pr-clusterctl-404-error
branch
from
48d467a
to
42e0607
Compare
k8s-ci-robot
added
size/M
|
/retitle 🐛 clusterctl: return early if release for latest tag does not exist yet |
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chrischdi
force-pushed
the
pr-clusterctl-404-error
branch
from
42e0607
to
05bf57f
Compare
|
May needs adjustments after #8240 merges |
ykakarap
reviewed
Mar 11, 2023
k8s-ci-robot
added
the
needs-rebase
chrischdi
force-pushed
the
pr-clusterctl-404-error
branch
from
05bf57f
to
c34d48e
Compare
k8s-ci-robot
removed
the
needs-rebase
chrischdi
force-pushed
the
pr-clusterctl-404-error
branch
from
c34d48e
to
9a1b6a8
Compare
chrischdi
force-pushed
the
pr-clusterctl-404-error
branch
from
9a1b6a8
to
be16f6c
Compare
|
@fabriziopandini / @ykakarap , apologise for the ping :-) buy could you give it another look? |
|
Overall LGTM. Just one nit: #8253 (comment) |
|
lgtm pending the change to the error message suggested by @ykakarap |
chrischdi
force-pushed
the
pr-clusterctl-404-error
branch
from
be16f6c
to
e3f73a6
Compare
|
Fixed + squashed :-) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 84bd56f17a9e465b72222c09802e0545f5487033
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykakarap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.4 |
|
@killianmuldoon: new pull request created: #8965 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
prasad-shirodkar
added a commit
to verrazzano/verrazzano
that referenced
this pull request
Aug 29, 2023
…r-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
prasad-shirodkar
added a commit
to verrazzano/verrazzano
that referenced
this pull request
Aug 29, 2023
…r-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
prasad-shirodkar
added a commit
to verrazzano/verrazzano
that referenced
this pull request
Aug 29, 2023
Updated capi ApplyUpgradeOptions when capi version overrides are specified Setting GOPROXY to direct to avoid Not Found 404 errors due to cluster-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
prasad-shirodkar
added a commit
to verrazzano/verrazzano
that referenced
this pull request
Aug 30, 2023
Updated capi ApplyUpgradeOptions when capi version overrides are specified Setting GOPROXY to direct to avoid Not Found 404 errors due to cluster-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
prasad-shirodkar
added a commit
to verrazzano/verrazzano
that referenced
this pull request
Aug 30, 2023
…#6909) Updated capi ApplyUpgradeOptions when capi version overrides are specified Setting GOPROXY to direct to avoid Not Found 404 errors due to cluster-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the ability to detect a 404 error from the github client and handle the error differently than just bubbling up the usual error message.
It now also does not retry fetching the release on 404 errors and immediately returns instead.
Old output was (after 1m timeout):
New output is:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Partially fixing #7889