-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 test/e2e: use topology cluster-template for clusterctl upgrade mgmt cluster #8311
🐛 test/e2e: use topology cluster-template for clusterctl upgrade mgmt cluster #8311
Conversation
/test pull-cluster-api-e2e-full-main |
cluster Signed-off-by: Stefan Büringer buringerst@vmware.com
25a9ac1
to
99761eb
Compare
/test pull-cluster-api-e2e-full-main |
/assign @fabriziopandini @killianmuldoon |
/cherry-pick release-1.3 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.4 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 86ff935118b65b14cebb30e71468c87bfd3bc250
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: #8311 failed to apply on top of branch "release-1.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #8314 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon Tested this PR by running the v0.3 clusterctl upgrade test locally which didn't work before (although my sample size was small). Would be great if you can also do a test on Tuesday (IIRC you definitely hit the issue every time) |
@@ -126,7 +136,10 @@ var _ = Describe("When testing clusterctl upgrades using ClusterClass (v1.2=>cur | |||
// try to deploy the latest version of our test-extension from docker.yaml. | |||
InitWithRuntimeExtensionProviders: []string{}, | |||
InitWithKubernetesVersion: "v1.26.0", | |||
WorkloadFlavor: "topology", | |||
// TODO(sbueringer) The topology flavor enables PSA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I follow-up on this TODO once I'm back from PTO in April
@sbueringer both tests are running for me locally now - thanks for tracking that down.! |
Thx for verifying!! |
/area e2e-testing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This should make the v0.3, v0.4 & v1.0 clusterctl upgrades more stable.
Currently they are using the default flavor. But the default flavor is not setting the cgroupDriver to cgroupfs for Kubernetes < 1.24.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #