Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] 🐛 test/e2e: use topology cluster-template for clusterctl upgrade mgmt cluster #8315

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
Cherry-pick of #8311

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

cluster

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Mar 20, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-release-1-3

@sbueringer
Copy link
Member Author

/assign @fabriziopandini @killianmuldoon

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on getting CI stable
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 47bfd337d0b86423213f420202b11c2bc9753117

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7144f14 into kubernetes-sigs:release-1.3 Mar 20, 2023
@sbueringer sbueringer deleted the pr-clusterctl-upgrade-fix-1.3 branch March 20, 2023 09:25
@sbueringer
Copy link
Member Author

@furkatgofurov7 @killianmuldoon @ykakarap @fabriziopandini

This broke e2e-mink8s on release-1.3 as it has ClusterTopology disabled.

I would propose to use Kubernetes 1.22 for the e2e-mink8s test so we can enable ClusterTopology: https://github.com/kubernetes/test-infra/pull/29094/files

I think this is simpler then trying to do bigger changes on the release-1.3 branch to use the right cgroupDriver without ClusterClass.

I think as we already have a few 1.3 patch releases out we can remain confident regardless that 1.3 works with Kubernetes 1.20 management clusters

@sbueringer
Copy link
Member Author

Btw for this case #8224 would have helped. But as of today it's not possible to run e2e-mink8s on PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants