Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster API: use 1.22 mgmt cluster for v1.3 e2e-mink8s periodic #29094

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Cluster API: use 1.22 mgmt cluster for v1.3 e2e-mink8s periodic #29094

merged 1 commit into from
Mar 21, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

@sbueringer
Cluster API: use 1.22 mgmt cluster for v1.3 e2e-mink8s periodic
819c1f8 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 21, 2023
sbueringer
sbueringer commented Mar 21, 2023
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-3.yaml
# Because of that we usually would test with v1.20, but because ClusterClass
# requires at least 1.22 we are using 1.22 instead.
# Note: We need ClusterClass for the clusterctl upgrade tests, so we're able to
# create clusterctl with old versions with the right cgroupDriver configuration.
- name: KUBERNETES_VERSION_MANAGEMENT
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now need 1.22 as this PR (kubernetes-sigs/cluster-api#8315) started to use ClusterClass for the clusterctl upgrade tests (to be able to use the right cgroupDriver for workload clusters with Kubernetes 1.21 & 1.23)

ykakarap
ykakarap approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, ykakarap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5e3b70b into kubernetes:master Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-release-1-3.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-3.yaml

In response to this:

Signed-off-by: Stefan Büringer buringerst@vmware.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-bump-1.3-mink8s-version branch March 21, 2023 04:37
@sbueringer sbueringer mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap approved these changes

@detiber detiber Awaiting requested review from detiber

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @ykakarap