🐛 test/framework fix docker pod log collector #8634
Conversation
When using ExecContainerInput to create the tarball, the same buffer got used for stdout and stderr. This broke the tarball which resulted in not extracting the files.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
Hit a flake, other jobs now show the pod logs 👍 /test pull-cluster-api-e2e-informing-ipv6-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: dc345437ee1efb24faa5ddc420293f795e30bb9d
|
|
Thx! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.4 |
k8s-ci-robot
added
the
approved
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.3 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer: new pull request created: #8643 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer: new pull request created: #8644 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/area testing |
|
/area e2e-testing |
|
/remove-area testing |
What this PR does / why we need it:
When using ExecContainerInput to create the tarball, the same buffer got used for stdout and stderr. This broke the tarball which resulted in not extracting the files and having them not available in artifacts.
I noticed this when I wanted to debug a failed e2e test.
All e2e tests currently log the following per machine (no matter of succeeded or failed):
And this should be resolved by this MR.
We maybe should cherry-pick this to v1.4 and v1.3?
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #