-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.3] 🐛 test/framework fix docker pod log collector #8644
[release-1.3] 🐛 test/framework fix docker pod log collector #8644
Conversation
When using ExecContainerInput to create the tarball, the same buffer got used for stdout and stderr. This broke the tarball which resulted in not extracting the files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 5c53345ae3b3e155bd3e698a02c63057beb88579
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area testing |
/area e2e-testing |
/remove-area testing |
This is an automated cherry-pick of #8634
/assign sbueringer