🌱 Pin cgroup driver used in v0.3 and v0.4 templates #8684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/e2e-testing
|
/test pull-cluster-api-e2e-full-main |
k8s-ci-robot
added
the
size/XS
sbueringer
reviewed
May 17, 2023
killianmuldoon
force-pushed
the
pr-pin-cgroup-driver-v0.3-v0.4
branch
from
2f7e18d
to
75bb7d0
Compare
k8s-ci-robot
added
size/S
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-pin-cgroup-driver-v0.3-v0.4
branch
from
75bb7d0
to
f2f566b
Compare
k8s-ci-robot
added
size/M
|
/test pull-cluster-api-e2e-full-main |
|
Thx! /lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ca866983ab5095e21d21a4cae55ace6803420dd8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
We should probably (manually) backport for consistency |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin the cgroup driver used in templates for v0.3 and v0.4. This is required when running the tests locally - otherwise the created clusters end up with crashing control plane pods.
Should hopefully also work in CI, but these tests have been generally stable in CI without pinning the versions.
/area e2e-testing