-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update golangci-lint to v1.53.3 #8796
🌱 Update golangci-lint to v1.53.3 #8796
Conversation
027a495
to
b6d826d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area dependency
/lgtm Let's please hold until the goofy PR is merged (I think golangci-lint is not urgent and I don't want to rebase the goofy PR more often than necessary). /hold |
LGTM label has been added. Git tree hash: 4360ca4ff7b92e7d6f14493289fa3c1bfa9807c7
|
Sure thing - I don't think there should be too much conflict between this and that, and I can update this PR with whatever findings there might be for goofy. |
Yup. There should be ~ no overlap regarding what currently is in this PR. It's mostly about the new findings in the ~ 5,5k Go LOC in the goofy PR :) |
/test pull-cluster-api-e2e-full-main As this now touches a bunch of e2e code. |
Some of these changes - e.g. fixing the asserts on ginkgo - should be cherry-picked to release 1.3 and release 1.4 |
@killianmuldoon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
4096b1c
to
76b0b01
Compare
/hold cancel Should probably re-run golangci-lint now that we merged the in-memory provider. Not sure if it strictly requires a rebase onto main. Probably yes. (definitely locally if you have to fix new findings obviously :D) |
Thx |
LGTM label has been added. Git tree hash: d508a2c4eb48a55ae249615ed9b578e57d8a3919
|
/lgtm |
Great job! |
/hold cancel |
/hold Sorry missed the squash |
4a447a4
to
54ca25c
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
54ca25c
to
3e16abc
Compare
/lgtm |
LGTM label has been added. Git tree hash: 1d6366c0586cb335792d606782640c87214e4929
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Update golangci-lint to v1.53.2.
Release notes: https://github.com/golangci/golangci-lint/releases/tag/v1.53.2
Changes:
ctrl.Result
where it was always nildepguard
which now requires a default config with all of the dependencies allowed or disallowed.Fixes #8050