🐛 test/e2e/in-memory: set providerID after VM is provisioned #8879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/M
sbueringer
commented
Jun 19, 2023
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Show resolved
Hide resolved
sbueringer
force-pushed
the
pr-im-node-fix
branch
from
91cc3ab
to
91daba7
Compare
k8s-ci-robot
added
the
cncf-cla: yes
sbueringer
force-pushed
the
pr-im-node-fix
branch
from
91daba7
to
9742027
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b2da90a36d14b62aa72a7e02861094cc2b8de478
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-im-node-fix
branch
from
9742027
to
6e3ab71
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/M
|
I dropped the change to enable the tests again. This PR now only contains moving the providerID and a fix for StartupJitter but without enabling all tests for CI. We need another iteration to resolve all issues |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 900fbee18d1d25b5b74b81d2d1f681cab5d26647
|
|
/area provider/infrastructure-in-memory |
k8s-ci-robot
added
the
area/provider/infrastructure-in-memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This PR changes the in-memory provider to set the providerID already after the VM is provisioned not after the Node is ready.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #