-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 test/e2e/in-memory: set providerID after VM is provisioned #8879
Conversation
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Show resolved
Hide resolved
91cc3ab
to
91daba7
Compare
91daba7
to
9742027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix!
/lgtm
/approve
LGTM label has been added. Git tree hash: b2da90a36d14b62aa72a7e02861094cc2b8de478
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Signed-off-by: Stefan Büringer buringerst@vmware.com
9742027
to
6e3ab71
Compare
I dropped the change to enable the tests again. This PR now only contains moving the providerID and a fix for StartupJitter but without enabling all tests for CI. We need another iteration to resolve all issues |
/hold cancel |
/lgtm |
LGTM label has been added. Git tree hash: 900fbee18d1d25b5b74b81d2d1f681cab5d26647
|
/area provider/infrastructure-in-memory |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This PR changes the in-memory provider to set the providerID already after the VM is provisioned not after the Node is ready.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #