Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test/e2e/in-memory: enable unit tests #8886

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 19, 2023

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR contains #8879 + enable tests

Kudos to @fabriziopandini for the second half of the implementation :)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2023
@sbueringer sbueringer force-pushed the pr-im-enable-tests branch 2 times, most recently from f218420 to 25dd36a Compare June 19, 2023 17:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2023
@sbueringer sbueringer changed the title [WIP] test/e2e/in-memory: enable tests [WIP] 🌱 test/e2e/in-memory: enable tests Jun 19, 2023
Signed-off-by: Stefan Büringer buringerst@vmware.com
Co-authored-by: Fabrizio Pandini fpandini@vmware.com
@sbueringer sbueringer changed the title [WIP] 🌱 test/e2e/in-memory: enable tests 🌱 test/e2e/in-memory: enable tests Jun 19, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2023
@sbueringer sbueringer changed the title 🌱 test/e2e/in-memory: enable tests 🌱 test/e2e/in-memory: enable unit tests Jun 19, 2023
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
for ci

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1039f16df9658d64b606109f5fcba0f5d1d8a3f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit e82db96 into kubernetes-sigs:main Jun 20, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 20, 2023
@sbueringer sbueringer deleted the pr-im-enable-tests branch June 20, 2023 07:52
@killianmuldoon
Copy link
Contributor

/area provider/infrastructure-in-memory

@k8s-ci-robot k8s-ci-robot added the area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants