-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 🐛 Retry Node delete when CCT is locked #9583
[release-1.4] 🐛 Retry Node delete when CCT is locked #9583
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area machine
/lgtm
/approve
LGTM label has been added. Git tree hash: beaca3bdec11491c8842afafa093afaaae17e334
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1d954c3
into
kubernetes-sigs:release-1.4
@@ -582,7 +582,11 @@ func (r *Reconciler) drainNode(ctx context.Context, cluster *clusterv1.Cluster, | |||
|
|||
restConfig, err := remote.RESTConfig(ctx, controllerName, r.Client, util.ObjectKey(cluster)) | |||
if err != nil { | |||
log.Error(err, "Error creating a remote client while deleting Machine, won't retry") | |||
if errors.Is(err, remote.ErrClusterLocked) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@killianmuldoon can we revert this part? remote.RESTConfig never returns this error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - I'll revert
This is an automated cherry-pick of #9570
/assign killianmuldoon