Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Remove maintainer role in release team and improve release team docs #9640

Merged
merged 3 commits into from
Nov 29, 2023
Merged

📖 Remove maintainer role in release team and improve release team docs #9640

merged 3 commits into from
Nov 29, 2023

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Oct 30, 2023 •
edited

What this PR does / why we need it:
This PR adds all missing tasks/notes that are either missing or not clearly enough documented in the release team docs in general. It also:

  • moves around some RL tasks in time chronological order
  • documents optional tasks for the Release Lead in the release tasks list.
  • clarifies RT and Release Day Meetings venue/time/day etc
  • fixes a doctoc issues in the release-team.md and proposals folder
  • documents a task from Improvement tasks for v1.6 release cycle #9104
Doc improvement: communication guidelines (moved from Misc section)
Public should be default - it gives visibility on the work being done, it is inclusive, it is a track of record -
Group DM as a safe space, but not for the actual work

Fixes: #9726

/area release
/kind documentation

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2023
@furkatgofurov7
Copy link
Member Author

cc @kubernetes-sigs/cluster-api-maintainers
@kubernetes-sigs/cluster-api-release-team

@furkatgofurov7 furkatgofurov7 mentioned this pull request Oct 31, 2023
Closed
35 tasks
killianmuldoon
killianmuldoon reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c8dcadbf8d60a1d718169c5f8cec7c1be603ef3

@g-gaston
Copy link
Contributor

g-gaston commented Nov 1, 2023

/lgtm

sbueringer
sbueringer reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for updating the doc, one nit

docs/release/release-tasks.md Outdated
Comment on lines 168 to 157
#### Set a tentative release date for the next minor release

1. Set a tentative release date for the next minor release and document it by creating a `release-X.Y.md` in [docs/release/releases](../../docs/release/releases).
<br>Prior art: https://github.com/kubernetes-sigs/cluster-api/pull/9635

#### Assemble next release team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to update the issue template to not break links from there to these two headlines

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding, updated now

@sbueringer sbueringer mentioned this pull request Nov 15, 2023
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2023
@furkatgofurov7
Add missing tasks and improve release team docs
7aac1a3 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Remove "Maintainer" role related notes and document responsibilities …
bc94027 
…in the release process

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Fix doctoc issues in docs/proposals repo
724542c 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 mentioned this pull request Nov 28, 2023
Closed
CecileRobertMichon
CecileRobertMichon reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e9622fb23615c6f27cbdb4a607dfa4183df947fb

@furkatgofurov7
Copy link
Member Author

cc @vincepri

@furkatgofurov7
Copy link
Member Author

/retitle 📖 Remove maintainer role in release team and improve release team docs

@k8s-ci-robot k8s-ci-robot changed the title 📖 Add missing tasks and improve release team docs 📖 Remove maintainer role in release team and improve release team docs Nov 29, 2023
vincepri
vincepri approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6b51698 into kubernetes-sigs:main Nov 29, 2023
39 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Nov 29, 2023
@furkatgofurov7 furkatgofurov7 deleted the clarify-rl-tasks branch November 29, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@vincepri vincepri vincepri approved these changes

@chrischdi chrischdi Awaiting requested review from chrischdi

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

@g-gaston g-gaston Awaiting requested review from g-gaston

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@g-gaston g-gaston

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Do we need "maintainer" role in the upcoming Release Teams
7 participants
@furkatgofurov7 @k8s-ci-robot @g-gaston @vincepri @sbueringer @CecileRobertMichon @killianmuldoon