Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Promote chrischdi to Cluster API maintainer #9997

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

This PR adds @chrischdi (that's me 馃槀 ) to cluster-api-maintainers.

I'm now working with the community and am contributing to the CAPI project for a good amount of time and also a reviewer for quite some time. I especially did work on ClusterClass features and on keeping the CI stable, deflaking issues, doing reviews, ... and want to continue with that in future.

I don't think we have the data quality to filter down for those specific areas so I'll just list all CAPI contributions:

/hold for consensus and community meeting

/cc @sbueringer

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area community-meeting

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2024
@killianmuldoon
Copy link
Contributor

+10000000000000000
/lgtm

Thanks for everything you've been doing across the repo! It's getting hard to keep up 馃槄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fd49bddf6b8652851c6ebf99d80a9611c94d0e6

@sbueringer
Copy link
Member

Thank you very much for all the work you're doing an Cluster API. It really is crucial to keep the project healthy !!!!

Also +10000000000000000 from my side :)

/lgtm

@fabriziopandini
Copy link
Member

Big +1! @chrischdi has been consistently doing a ton of great work in CAPI and CAPV for some time now, super well-deserved
/lgtm

@elmiko
Copy link
Contributor

elmiko commented Jan 17, 2024

+1, thanks for all the hard work Christian

@neolit123
Copy link
Member

+1

@sbueringer
Copy link
Member

As mentioned in the office hours, 1 week lazy consensus

@sbueringer
Copy link
Member

/cc @fabriziopandini @enxebre @vincepri @killianmuldoon @CecileRobertMichon

@CecileRobertMichon
Copy link
Contributor

+1 from my side as well, thank you for all your contributions so far!!

/lgtm

@chrischdi
Copy link
Member Author

Thanks everyone for the help and support on this journey 馃帀 馃憤

@enxebre
Copy link
Member

enxebre commented Jan 18, 2024

Nice, thanks @chrischdi!

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@fabriziopandini
Copy link
Member

As per office hours
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 24, 2024
@chrischdi
Copy link
Member Author

Rebased, #10042 hit the merge train faster 馃槀

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 10a3b2032d20910b1469888beb5be4f8cbac9c4b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants