Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-cluster-lifecycle/cluster-api: add chrischdi to maintainers #6356

Merged

Conversation

chrischdi
Copy link
Member

Adding myself to the approvers for cluster-api relevant staging images.

xref:

kubernetes-sigs/cluster-api#9997

/assign sbueringer

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2024
@ameukam
Copy link
Member

ameukam commented Feb 1, 2024

No need to update the k8s.gcr.io path. We stopped to do promotions to k8s.gcr.io

@neolit123
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@sbueringer
Copy link
Member

No need to update the k8s.gcr.io path. We stopped to do promotions to k8s.gcr.io

Makes sense. But should be fine either way I guess

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. labels Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member Author

chrischdi commented Feb 2, 2024

Removed from the old registry part (to get rid of do-not-merge/blocked-path).

@ameukam
Copy link
Member

ameukam commented Feb 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1baed3e into kubernetes:main Feb 2, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 2, 2024
@sbueringer
Copy link
Member

Removed from the old registry part (to get rid of do-not-merge/blocked-path).

Ah wasn't aware it's blocked on this level :D. Then it makes sense to not add yourself there of course

@chrischdi chrischdi deleted the pr-capi-chrischdi-maintainer branch February 2, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants