Merge pull request #786 from vincepri/fix-body-leak

🐛 Integration test should close http body
kubernetes-sigs · Feb 10, 2020 · 702a4a4 · 702a4a4
2 parents 82a78f9 + 6a43798
commit 702a4a4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/hack/verify.sh b/hack/verify.sh
@@ -42,6 +42,7 @@ golangci-lint run --disable-all \
     --enable=lll \
     --enable=dupl \
     --enable=goimports \
+    --enable=bodyclose \
     ./pkg/... ./examples/... .
 
 # TODO: Enable these as we fix them to make them pass

diff --git a/pkg/internal/testing/integration/internal/process.go b/pkg/internal/testing/integration/internal/process.go
@@ -170,9 +170,12 @@ func pollURLUntilOK(url url.URL, interval time.Duration, ready chan bool, stopCh
 	}
 	for {
 		res, err := http.Get(url.String())
-		if err == nil && res.StatusCode == http.StatusOK {
-			ready <- true
-			return
+		if err == nil {
+			res.Body.Close()
+			if res.StatusCode == http.StatusOK {
+				ready <- true
+				return
+			}
 		}
 
 		select {