Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Integration test should close http body #786

Merged
merged 2 commits into from
Feb 10, 2020
Merged

馃悰 Integration test should close http body #786

merged 2 commits into from
Feb 10, 2020

Conversation

vincepri
Copy link
Member

This PR makes sure the pollURLUntilOK function closes the body from http.Get if there is no error, and adds bodyclose linter to the enabled linters.

@vincepri
馃悰 Integration test should close http body
4574014 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@vincepri
馃弮 Enable bodyclose linter
6a43798 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2020
alvaroaleman
alvaroaleman approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @gerred

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2020
alenkacz
alenkacz approved these changes Feb 1, 2020
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mengqiy
Copy link
Member

mengqiy commented Feb 3, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@gerred
Copy link
Contributor

gerred commented Feb 3, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gerred, mengqiy, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri
Copy link
Member Author

vincepri commented Feb 4, 2020

/test pull-controller-runtime-test-master

@alenkacz
Copy link
Contributor

alenkacz commented Feb 4, 2020

@vincepri I fixed that flake 馃 - it's merged on master, you should rebase and rerun the tests :)

@alvaroaleman
Copy link
Member

@alenkacz Prow merges the PR prior to running tests, so the last run did have your change. You can see that by looking at the test page, then clicking on "ProwJob Yaml", then basesha, which is 5e2c4c8, which is the latest master

@alenkacz
Copy link
Contributor

alenkacz commented Feb 4, 2020

@alvaroaleman oooh, nice. but not nice that the fix did not work 馃槩

@alvaroaleman
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 702a4a4 into kubernetes-sigs:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz alenkacz approved these changes

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@alenkacz alenkacz

@gerred gerred

@mengqiy mengqiy

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vincepri @mengqiy @gerred @k8s-ci-robot @alenkacz @alvaroaleman