Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Integration test should close http body #786

Merged
merged 2 commits into from
Feb 10, 2020
Merged

馃悰 Integration test should close http body #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4574014
:bug: Integration test should close http body
vincepri Jan 31, 2020
6a43798
:running: Enable bodyclose linter
vincepri Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hack/verify.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ golangci-lint run --disable-all \
--enable=lll \
--enable=dupl \
--enable=goimports \
--enable=bodyclose \
./pkg/... ./examples/... .

# TODO: Enable these as we fix them to make them pass
Expand Down
9 changes: 6 additions & 3 deletions pkg/internal/testing/integration/internal/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,12 @@ func pollURLUntilOK(url url.URL, interval time.Duration, ready chan bool, stopCh
}
for {
res, err := http.Get(url.String())
if err == nil && res.StatusCode == http.StatusOK {
ready <- true
return
if err == nil {
res.Body.Close()
if res.StatusCode == http.StatusOK {
ready <- true
return
}
}

select {
Expand Down