Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting "UseExistingCluster" via OS Env #222

Closed
ichekrygin opened this issue Nov 24, 2018 · 6 comments
Closed

Allow setting "UseExistingCluster" via OS Env #222

ichekrygin opened this issue Nov 24, 2018 · 6 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
0.2.0

Comments

@ichekrygin
Copy link
Contributor

Currently, controller-runtime does not support setting UseExistingCluster dynamically via environment variables (similarly to envKubeAPIServerBin or envEtcdBin, etc.).

It would be very convenient and helpful to provide a uniform way in which users can dynamically set the option to UseExistingCluster via the environment.
@ichekrygin ichekrygin mentioned this issue Nov 24, 2018
Closed
@DirectXMan12
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 16, 2019
@DirectXMan12 DirectXMan12 added this to the 0.2.0 milestone Jan 16, 2019
@DirectXMan12
Copy link
Contributor

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 16, 2019
@DirectXMan12
Copy link
Contributor

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 6, 2019
@adohe-zz adohe-zz mentioned this issue May 27, 2019
Merged
@DirectXMan12 DirectXMan12 mentioned this issue May 31, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2019
@DirectXMan12
Copy link
Contributor

done

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
Merge pull request #222 from pwittrock/analytics
7670713 
GoogleAnalytics for GitBook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
4 participants
@DirectXMan12 @ichekrygin @k8s-ci-robot @fejta-bot