Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UseExistingCluster a pointer? #461

Closed
DirectXMan12 opened this issue May 31, 2019 · 2 comments
Closed

Make UseExistingCluster a pointer? #461

DirectXMan12 opened this issue May 31, 2019 · 2 comments
Milestone
0.2.0

Comments

@DirectXMan12
Copy link
Contributor

#449 allows setting UseExistingCluster via an env var, but as discussed in #222, we probably want a pointer. Without the pointer, we don't have a way to explicitly opt-out in the code (we really want a 3-state enum: true, false, and UseEnvVar).
@DirectXMan12 DirectXMan12 added this to the 0.2.0 milestone May 31, 2019
@adohe-zz adohe-zz mentioned this issue Jun 2, 2019
Merged
@adohe-zz
Copy link

/close

@k8s-ci-robot
Copy link
Contributor

@adohe: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
3 participants
@DirectXMan12 @adohe-zz @k8s-ci-robot