⚠️ make UseExistingCluster a pointer to support explicitly op… #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/assign @DirectXMan12 |
adohe-zz
force-pushed
the
make_useexistingcluster_pointer
branch
from
7005c81
to
a0caa74
Compare
DirectXMan12
suggested changes
Jun 4, 2019
pkg/envtest/server.go
Outdated
| func (te *Environment) useExistingCluster() bool { | ||
| if te.UseExistingCluster == nil { | ||
| useExistingCluster := strings.ToLower(os.Getenv(envUseExistingCluster)) == "true" | ||
| te.UseExistingCluster = &useExistingCluster |
There was a problem hiding this comment.
no need to populate this here -- just return the env var without populating
adohe-zz
force-pushed
the
make_useexistingcluster_pointer
branch
from
a0caa74
to
c9aad37
Compare
DirectXMan12
suggested changes
Jun 6, 2019
pkg/envtest/server.go
Outdated
| if te.UseExistingCluster == nil { | ||
| return strings.ToLower(os.Getenv(envUseExistingCluster)) == "true" | ||
| } | ||
| return *te.UseExistingCluster == true |
There was a problem hiding this comment.
nit: no need for == true here, since it's a bool
adohe-zz
force-pushed
the
make_useexistingcluster_pointer
branch
from
c9aad37
to
0d3fbbc
Compare
|
comment addressed and CI happy @DirectXMan12 ptal |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adohe, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
use controller-runtime logging in controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t-out in the code
just as what #461 mentioned, make UseExistingCluster a pointer thus gives a way to explicitly opt-out in the code.