Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging should be streamlined #291

Closed
vincepri opened this issue Jan 10, 2019 · 3 comments
Closed

Logging should be streamlined #291

vincepri opened this issue Jan 10, 2019 · 3 comments
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@vincepri
Copy link
Member

The current controller runtime offers a log package that includes a zap logger and lets users to bring their own logger by implementing https://github.com/go-logr/logr interfaces. Most of the other tools in the Kubernetes ecosystem use klog as the main logging point, which makes it hard to have a single output and logger given that klog doesn't expose any interface that implements logr interfaces.

Some related issues in the community:
@DirectXMan12
Copy link
Contributor

github.com/go-logr/glogr should be trivially adaptable to klog (it was originally written for glog). We'll see how klog evolves, but getting that situation squared away is something I would definitely like to do.

@DirectXMan12
Copy link
Contributor

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 15, 2019
@DirectXMan12
Copy link
Contributor

kubernetes/klog#37 at least partially solves this problem with its klogr package. The other half is being worked on it kubernetes/klog#20.

@johnugeorge johnugeorge mentioned this issue May 13, 2019
Closed
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request #291 from briantkennedy/master
5db3f0d 
Change enqueuing items to use Add instead of AddRateLimited.
@camilamacedo86 camilamacedo86 mentioned this issue Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DirectXMan12 @vincepri @camilamacedo86 @k8s-ci-robot