-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose newResourceLock in manager.Options so that controllers can use customized resourceLock #534
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/close |
@jzhoucliqr: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📖 updated version in installation instructions
I have a use case to run a standalone aggregation-apiserver without native kube-apiserver. To enable leader selection for controllers, currently controller-runtime hardcode to use configmapLocks, which won't work for this case because configmap resource is not available in the aggregation-apiserver.
If we expose newResourceLock outside of manager.Options, then controllers can their own customized resourcelocks, and leader selection can work without native kube-apiserver.
This is a minor change, but will be very beneficial for standalone apiservers/controllers.
What do you guys think? I can have a PR if we agree this is a valid use case.
The text was updated successfully, but these errors were encountered: