-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ expose NewResourceLock in manager.Options #535
✨ expose NewResourceLock in manager.Options #535
Conversation
…omized resourcelock for leader selection
Welcome @jzhoucliqr! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jzhoucliqr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@jzhoucliqr: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@DirectXMan12 @pwittrock Do you have time to take a quick look at this PR? Thanks. |
I'm not sure this is the interface we want to expose -- the particulars of the resource lock are mainly an implementation detail at this point, and this adds yet another piece of client-go to our public API, which increases the chance that things will arbitrarily break in the future. That being said, I'll have to take a closer look to see what our options are. |
closing in favor of #600 |
This is to enable controllers to use customized resource locks for leader election.
It is for the use case that a standalone aggregation-like apiserver running without native kube-apiserver, thus the corev1 resources are not available through apiserver REST API.
With this, Mangers can use customized resourceLocks, without relying on corev1 resources.
Closes #534