fix nil stop value for source.Channel #204
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
DirectXMan12
force-pushed
the
bug/stop-channel-borked
branch
from
977e1fa
to
83939b1
Compare
k8s-ci-robot
added
size/M
|
@mindprince @droot please take a quick look, but this should be all set |
|
@mindprince: changing LGTM is restricted to assignees, and only kubernetes-sigs/controller-runtime repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixes kubernetes-sigs#103 Creates a stop channel for the manager in New(), which will get passed to any source.Channel instances that are added. When the manager's start method is called and a new stop channel is passed in, that channel will be joined in a goroutine with the manager's existing channel so that if the newer channel gets closed, so will the manager's.
This cleans up, adds comments, and renames things in the stop channel fix commits for clarity.
This will match the version currently used in Kubernetes.
DirectXMan12
force-pushed
the
bug/stop-channel-borked
branch
from
029f9c8
to
fc38a77
Compare
Unparam is complaining of an usused param in cache.Reader in Travis (but somehow only on Travis?). This fixes that.
droot
added
the
lgtm
…nnel-borked fix nil stop value for source.Channel
Creates a stop channel for the manager in New(), which will get passed to any
source.Channel instances that are added. When the manager's start method is
called and a new stop channel is passed in, that channel will be joined in a
goroutine with the manager's existing channel so that if the newer channel gets
closed, so will the manager's.
Fixes #103