Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil stop value for source.Channel #204

Merged

Commits on Nov 12, 2018

  1. fix nil stop value for source.Channel

    fixes kubernetes-sigs#103
    
    Creates a stop channel for the manager in New(), which will get passed to any
    source.Channel instances that are added. When the manager's start method is
    called and a new stop channel is passed in, that channel will be joined in a
    goroutine with the manager's existing channel so that if the newer channel gets
    closed, so will the manager's.
    mhrivnak authored and DirectXMan12 committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    a7f0df0 View commit details
    Browse the repository at this point in the history
  2. Stop channel commenting/renaming for clarity

    This cleans up, adds comments, and renames things in the stop channel
    fix commits for clarity.
    DirectXMan12 committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    e0ee559 View commit details
    Browse the repository at this point in the history
  3. [travis] Bump Go to 1.11

    This will match the version currently used in Kubernetes.
    DirectXMan12 committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    fc38a77 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. Unused param in cache.Reader

    Unparam is complaining of an usused param in cache.Reader in Travis (but
    somehow only on Travis?).  This fixes that.
    DirectXMan12 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    071c3a2 View commit details
    Browse the repository at this point in the history