-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove global metrics registration in init, add registration func #2240
Closed
austince
wants to merge
1
commit into
kubernetes-sigs:main
from
austince:feat-remove-global-metrics-provider
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the k/k pr, we wont merge this. This breaks the majority use-case (
workqueue metrics just work without doing anything
) in order to support a minority use-case (set custom provider
)./hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not what you were suggesting here? kubernetes/kubernetes#114242 (comment)
This is marked as a breaking change, and allows consumers to set it. Unsure what the path forward is if it is neither of the options I've proposed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, my suggestion was to change the upstream workqueue to not use a sync.Once so what is set by controller-runtime can be overridden later if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'll send a PR for that -- seems to paper over the fact that this library is mutating global state and the "metrics just work without doing anything" use case could be addressed somewhere else (like kubebuilder, which sets up a
main
), but if this gets it in 🤷🏼I'll leave this open in the meantime if others want to weigh in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing kubebuilder does not really mitigate the situation. I don't have a good overview over the ecosystem but the controllers that I'm aware of don't regularly regenerate their main file with kubebuilder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okie, I'll close this then -- I've also got a PR for what Alvaro suggested here, if you guys want to drive that approach: kubernetes/kubernetes#116616