-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Flatten fields in controller.Options #2307
⚠️ Flatten fields in controller.Options #2307
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
74bcf1e
to
9d38074
Compare
9d38074
to
06948ce
Compare
Currently, `controller.Options` embedds `config.Controller`. This makes its usage pretty annoying, to set `MaxConcurrentReconciles` for example, one has to do it like this: ``` controller.Options{config.Options{MaxConcurrentReconciles: 8}} ``` This makes it harder to find what options exist and causes a lot of churn for downstream consumers. Re-Define the fields from `config.Controller` in `controller.Options` instead to avoid that. This also fixes some defaulting bugs where we wouldn't default `MaxConcurrentReconciles` and `CacheSyncTimeout` from the `config.Controller` setting in the manager.
06948ce
to
c1b8baf
Compare
/lgtm /hold |
/hold cancel |
@alvaroaleman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Currently,
controller.Options
embeddsconfig.Controller
. This makes its usage pretty annoying, to setMaxConcurrentReconciles
for example, one has to do it like this:This makes it harder to find what options exist and causes a lot of churn for downstream consumers. Re-Define the fields from
config.Controller
incontroller.Options
instead to avoid that.This also fixes some defaulting bugs where we wouldn't default
MaxConcurrentReconciles
andCacheSyncTimeout
from theconfig.Controller
setting in the manager.