Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Flatten fields in controller.Options #2307

Merged

Commits on May 8, 2023

  1. :warn: Flatten fields in controller.Options

    Currently, `controller.Options` embedds `config.Controller`. This makes
    its usage pretty annoying, to set `MaxConcurrentReconciles` for example,
    one has to do it like this:
    
    ```
    controller.Options{config.Options{MaxConcurrentReconciles: 8}}
    ```
    
    This makes it harder to find what options exist and causes a lot of
    churn for downstream consumers. Re-Define the fields from
    `config.Controller` in `controller.Options` instead to avoid that.
    
    This also fixes some defaulting bugs where we wouldn't default
    `MaxConcurrentReconciles` and `CacheSyncTimeout` from the
    `config.Controller` setting in the manager.
    alvaroaleman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    c1b8baf View commit details
    Browse the repository at this point in the history