v0.1.8 #240
Merged
v0.1.8 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change exports DefaultKubeAPIServerFlags, allowing a user to append the default flags with other custom flags and set it to Environment.KubeAPIServerFlags. If KubeAPIServerFlags is not set, DefaultKubeAPIServerFlags is used when the API server starts.
Enabled Prometheus collector for process metrics and Go runtime
…-metrics added process metrics and Go runtime metrics
…PIServerFlags envtest: export DefaultKubeAPIServerFlags & make flags configurable
Refactor metrics tests
Signed-off-by: mooncake <xcoder@tenxcloud.com>
Signed-off-by: mooncake <xcoder@tenxcloud.com>
fixes kubernetes-sigs#103 Creates a stop channel for the manager in New(), which will get passed to any source.Channel instances that are added. When the manager's start method is called and a new stop channel is passed in, that channel will be joined in a goroutine with the manager's existing channel so that if the newer channel gets closed, so will the manager's.
This cleans up, adds comments, and renames things in the stop channel fix commits for clarity.
This will match the version currently used in Kubernetes.
Unparam is complaining of an usused param in cache.Reader in Travis (but somehow only on Travis?). This fixes that.
…nnel-borked fix nil stop value for source.Channel
Cleanup duplicated words
Fix typos: wehbook -> webhook
Adds a NewFakeClientWithScheme function that takes a *runtime.Scheme as its first argument. NewFakeClient is now a wrapper around NewFakeClientWithScheme, passing it the default scheme.Scheme. As part of this, the scheme can now be used to derive the correct List GVK. This eliminates the need to use a metav1.List and opts.Raw.TypeMeta. Now it's possible to pass in a typed List, same as with the real client.
This is enabled by new type support in fake client List. Other tests may also be updated to use this style.
metav1.List and corev1.List don't conform to the TypeList standard expected by getGVKFromList.
Co-Authored-By: grantr <grantr@gmail.com>
Add scheme support to fake client
Set GVK when getting the object from the cache.
Use typed lists in cert writer tests
This adds in documentation on versioning, branching, and maintenance. There's still a couple of places where we have to create scripts and fill in process, but this lays the initial groundwork.
…ng-strategy 📖 Versioning and Branching Strategy
The template picker only works for issues, but you can still have multiple PR templates that can be used with a query parameter, but that's kind-of unweildy. We'll have the default PR template, and keep the separate ones around linked-to from the readme as examples.
…-templates 🏃 Add default PR template
🐛 fix incorrect logr usage
🐛 Serve metrics even if not leader
✨ Update to Kubernetes 1.12.2
✨ Update to Kubernetes 1.12.3
This commit makes sure we're specific on what packages we "require" in Gopkg.toml. Erroneously requiring the root package in the apiextensions-apiserver, was causing us to pull in main, and transitively a whole bunch of deps that we didn't actually need.
This adds a "wrapper" to a Zap encoder designed to nicely log Kubernetes objects when in non-development mode. When in development mode, we still log the entire object.
This overhauls log tags in CR to ensure that we have consistent style and naming across all of our log lines.
This updates the dep list with the new zap/buffer dependency.
…y_default ✨ change metrics default to off
…ging-audit ✨ Ensure logging is uniform
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
|
/hold let me fire up the release notes script |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unhold |
|
/hold cancel |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v0.1.8