⚠ admission.Decoder is now an interface #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
The current implementation allows to create a decoder without
a scheme/codecs by just referencing the struct `&admission.Decoder{}`
given that codecs is private. The field was filled in before with the
inject package which has been removed. This change retains the Decoder
definition and makes it an interface, `admission.NewDecoder(scheme)` is
now the only way to instantiate our default decoder.
Signed-off-by: Vince Prignano <vincepri@redhat.com>
k8s-ci-robot
added
the
size/M
vincepri
force-pushed
the
decoder-interface
branch
from
d557775
to
04c37a9
Compare
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alvaroaleman
approved these changes
Mar 27, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jwsui
added a commit
to jwsui/nsx-operator
that referenced
this pull request
Apr 24, 2024
The controller-manager won't automatically inject decoder to webhook handler in new implementation, which will cause the panic error of webhook. Use admission.NewDecoder(scheme) instead as it is now the only way to instantiate default decoder. kubernetes-sigs/controller-runtime#2736
5 tasks
martinohmann
added a commit
to Bonial-International-GmbH/pod-image-swap-webhook
that referenced
this pull request
Jun 17, 2024
martinohmann
added a commit
to Bonial-International-GmbH/pod-image-swap-webhook
that referenced
this pull request
Jun 17, 2024
#126) * chore(deps): bump sigs.k8s.io/controller-runtime from 0.17.3 to 0.18.4 Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.17.3 to 0.18.4. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.3...v0.18.4) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: admission.Decoder is an interface now kubernetes-sigs/controller-runtime#2736 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Martin Ohmann <martin.ohmann@bonial.com>
peng225
added a commit
to topolvm/topolvm
that referenced
this pull request
Jun 26, 2024
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
peng225
added a commit
to topolvm/topolvm
that referenced
this pull request
Jun 26, 2024
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
peng225
added a commit
to topolvm/topolvm
that referenced
this pull request
Jun 26, 2024
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
peng225
added a commit
to topolvm/topolvm
that referenced
this pull request
Jun 27, 2024
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
peng225
added a commit
to topolvm/topolvm
that referenced
this pull request
Jun 28, 2024
admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation allows to create a decoder without a scheme/codecs by just referencing the struct
&admission.Decoder{}given that codecs is private. The field was filled in before with the inject package which has been removed. This change retains the Decoder definition and makes it an interface,admission.NewDecoder(scheme)is now the only way to instantiate our default decoder.Fixes #2695