hook: fix the decoder variable type

admission.Decoder has been changed to the interface, so the decoder variable should not be a pointer now. cf. kubernetes-sigs/controller-runtime#2736 Signed-off-by: Shinya Hayashi <shinya-hayashi@cybozu.co.jp>
topolvm · Jun 26, 2024 · 21a4dd6 · 21a4dd6
1 parent ddaeaff
commit 21a4dd6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/hook/mutate_persistentvolumeclaim.go b/internal/hook/mutate_persistentvolumeclaim.go
@@ -19,11 +19,11 @@ import (
 
 type persistentVolumeClaimMutator struct {
 	getter  *getter.RetryMissingGetter
-	decoder *admission.Decoder
+	decoder admission.Decoder
 }
 
 // PVCMutator creates a mutating webhook for PVCs.
-func PVCMutator(r client.Reader, apiReader client.Reader, dec *admission.Decoder) http.Handler {
+func PVCMutator(r client.Reader, apiReader client.Reader, dec admission.Decoder) http.Handler {
 	return &webhook.Admission{
 		Handler: &persistentVolumeClaimMutator{
 			getter:  getter.NewRetryMissingGetter(r, apiReader),

diff --git a/internal/hook/mutate_pod.go b/internal/hook/mutate_pod.go
@@ -28,11 +28,11 @@ var pmLogger = ctrl.Log.WithName("pod-mutator")
 // podMutator mutates pods using PVC for TopoLVM.
 type podMutator struct {
 	getter  *getter.RetryMissingGetter
-	decoder *admission.Decoder
+	decoder admission.Decoder
 }
 
 // PodMutator creates a mutating webhook for Pods.
-func PodMutator(r client.Reader, apiReader client.Reader, dec *admission.Decoder) http.Handler {
+func PodMutator(r client.Reader, apiReader client.Reader, dec admission.Decoder) http.Handler {
 	return &webhook.Admission{
 		Handler: &podMutator{
 			getter:  getter.NewRetryMissingGetter(r, apiReader),