⚠️ Use leader elector with client timeout #3028
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
force-pushed
the
timeout
branch
from
d827d3c to
53712f7
Compare
alvaroaleman
changed the title
This change makes the leader elector use a client that internally has a smaller timeout than the renew deadline, which avoids a situation where a single request timing out makes us lose the leader lease.
alvaroaleman
force-pushed
the
timeout
branch
from
53712f7 to
5bf5874
Compare
alvaroaleman
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: a7ebc71ff2612a7fe445a126bd5613ec6bb7740e
|
|
I would recommend backport, GKE backported if for critical controllers. |
|
/cherry-pick release-0.18 |
|
@vincepri: new pull request created: #3030 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vincepri: new pull request created: #3031 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // RewnewDeadline is the renew deadline for this leader election client | ||
| RewnewDeadline time.Duration |
There was a problem hiding this comment.
This should be RenewDeadline, right? Typo @alvaroaleman
|
@vincepri I don't think we can backport this, the leader election options where I added the paramter are exported, this change breaks anyone who uses that directly. Given that no one noticed this for years, I think its okay to not backport and wait for the next release |
This change makes the leader elector use a client that internally has a smaller timeout than the renew deadline, which avoids a situation where a single request timing out makes us lose the leader lease.
Fixes #3027